[Config] Make ecs.php extensible instead of fully replaceable#16
Closed
[Config] Make ecs.php extensible instead of fully replaceable#16
Conversation
- Introduce EcsConfigFactory class with create() and loadBaseConfiguration() methods - Update ecs.php to return ECSConfigBuilder directly for consumer extensibility - Add usage examples in docblocks for require + extend pattern - Add tests for EcsConfigFactory Implements: #6
Contributor
Author
|
Closing this PR because the changes introduced here became inconsistent and hard to review due to issues in the automated generation process. Instead of trying to fix this incrementally, the work will be redone in a clean, focused follow-up PR to ensure better structure, clarity, and reviewability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EcsConfigFactoryclass withcreate()andloadBaseConfiguration()methodsecs.phpto returnECSConfigBuilderdirectly for consumer extensibilityEcsConfigFactoryImplementation
The solution provides multiple ways for consumers to extend the ECS configuration:
return require __DIR__ . '/vendor/fast-forward/dev-tools/ecs.php';return EcsConfigFactory::create();return $builder->withRules([CustomRule::class]);This allows consumers to build on top of the base configuration without copying the entire file, preserving the ability to receive upstream updates automatically.
Closes #6